Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs #230

Merged
merged 1 commit into from Nov 26, 2020
Merged

Updated docs #230

merged 1 commit into from Nov 26, 2020

Conversation

ChocolateLoverRaj
Copy link
Contributor

Brief description

Closes #229
Updates readme.md and contributing.md to explain new way of building. It used to be with gulp, but now there is build/build.js. Also changes the contributing steps slightly by including the npm run css:build step and explaining more about what npm run start does.

Developer Certificate of Origin

@ChocolateLoverRaj ChocolateLoverRaj marked this pull request as ready for review November 16, 2020 23:31
rhyneav
rhyneav approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@rhyneav rhyneav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! Thank you for making these updates, it all looks great!

@rhyneav rhyneav merged commit 122dc74 into papercss:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhyneav rhyneav rhyneav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs for new build.
2 participants
@ChocolateLoverRaj @rhyneav