#281 - Add a count for customers created per day #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Add a customer test_changeset. This allows us to modify the `inserted_at` column in tests. - Add tests for count_customers_by_date methods. Separated from the other test blocks because we don't need to create a customer during the setup.
Also, add specs to new customer reporting methods
reichert621
reviewed
Oct 13, 2020
There was a problem hiding this comment.
looks great @jonathanyeong! :)
just one small nitpick and then should be good to merge 🎉
lib/chat_api/customers/customer.ex
Outdated
| @@ -102,4 +102,10 @@ defmodule ChatApi.Customers.Customer do | |||
| :time_zone | |||
| ]) | |||
| end | |||
|
|
|||
| def test_changeset(message, attrs) do | |||
| message | |||
There was a problem hiding this comment.
nit -- let's change message to customer
There was a problem hiding this comment.
Argh copy and paste error. Good catch thanks!
Darn copy and paste error.
3 tasks
reichert621
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds methods in Reporting to get the number of customers created per day.
Also:
inserted_atcolumn in tests.we don't need to create a customer during the setup.
Issue
#281
Checklist
mix testmix format