Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better support for private notes in Slack #562

Merged
merged 2 commits into from Feb 5, 2021
Merged

Add better support for private notes in Slack #562

merged 2 commits into from Feb 5, 2021

Conversation

reichert621
Copy link
Collaborator

@reichert621 reichert621 commented Feb 4, 2021 •
edited

Description

Add better support for private notes in Slack:

  • Display private notes in internal Slack integration when created from dashboard
  • Allow prefixing messages in Slack with \\ or ;; to create private note from within Slack
  • Remove these special prefix characters from messages internally
  • Write more tests
  • QA in staging

Issue

#560

Screenshots

In Slack (internal) In dashboard (internal) In chat widget (external)
Screen Shot 2021-02-04 at 4 29 16 PM Screen Shot 2021-02-04 at 4 29 37 PM Screen Shot 2021-02-04 at 4 29 55 PM

Checklist

  • Everything passes when running mix test
  • Ran mix format
  • No frontend compilation warnings

@reichert621 reichert621 merged commit 729cf04 into master Feb 5, 2021
@reichert621 reichert621 deleted the slack-private-notes branch February 5, 2021 15:00
@reichert621 reichert621 mentioned this pull request Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@reichert621