Skip to content
This repository has been archived by the owner on Jan 11, 2018. It is now read-only.

generate diff images and save in output directory #63

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

GelLiNN
Copy link

@GelLiNN GelLiNN commented Apr 7, 2016

@d3ming

Wraps imagemagick compare tool in tagcompare's image.py, and invokes that from tagtester's main.py

@d3ming
Copy link

d3ming commented Apr 7, 2016

Some general things:

  1. Make sure tests / flake8 pass by running tox locally
  2. Add test for the function you added in image.py

@GelLiNN GelLiNN force-pushed the master branch 2 times, most recently from f1c7ae4 to f8f0988 Compare April 8, 2016 20:51
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.822% when pulling f8f0988 on GelLiNN:master into 7ccc605 on paperg:master.

from tagcompare import image
from tagcompare import settings

settings.TEST_MODE = True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this. I think this flag is just set for cases where the test needs to use the flag. I'm honestly not sure I thought that through when I first used it so you shouldn't use it if you don't need to :)

@d3ming
Copy link

d3ming commented Apr 8, 2016

Looks good overall, just a couple of minor comments. Good to merge once you fix that
👍

@GelLiNN GelLiNN closed this Apr 11, 2016
@GelLiNN GelLiNN reopened this Apr 11, 2016
@GelLiNN GelLiNN force-pushed the master branch 2 times, most recently from 34604eb to a62de36 Compare April 11, 2016 19:56
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.822% when pulling a62de36 on GelLiNN:master into 7ccc605 on paperg:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.822% when pulling 9f44a5d on GelLiNN:master into 7ccc605 on paperg:master.

@GelLiNN GelLiNN merged commit 0363a5c into makethunder:master Apr 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants