Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps update #190

Merged
merged 7 commits into from
Aug 13, 2015
Merged

deps update #190

merged 7 commits into from
Aug 13, 2015

Conversation

nschloe
Copy link
Contributor

@nschloe nschloe commented Jul 28, 2015

We might want to wait for leaflet to release, cf. here and

+    "angular-leaflet-directive": "git@github.com:tombatossals/angular-leaflet-directive.git#3204bf304d74930704d2c3a6553c4da1c3952ee4",

@andrenarchy
Copy link
Member

angular-leaflet-directive has a new release, do you want to update?

@nschloe
Copy link
Contributor Author

nschloe commented Jul 28, 2015

@nschloe
Copy link
Contributor Author

nschloe commented Jul 28, 2015

Due to the updates, we now get a warning on the console reading

tooltip-html-unsafe is now deprecated. Use tooltip-html or tooltip-template instead.

I wasn't able to resolve it at this point, but re can worry about it later.

@andrenarchy
Copy link
Member

This is the copyright/license information tooltip. I'll prepare a commit later...

@nschloe
Copy link
Contributor Author

nschloe commented Jul 28, 2015

Yeap right. When I simply use tooltip-html as suggested in the warning, I'm getting

Uncaught Error: [$parse:lexerr] Lexer Error: Unterminated quote at columns 35-852 ['s html() -->
[...]

upon clicking on the tooltip.

With tooltip-template, the attribution directive doesn't require any
business logic any more: it's a simple template! \o/
@andrenarchy
Copy link
Member

The tooltip warning is gone by using tooltip-template. The attribution directive now actually is much cleaner because I could remove all the watch-magic.

But there are still issues that need to be resolved before merging:

@andrenarchy
Copy link
Member

angular-bootstrap 0.13.2 was released yesterday. It remains to check if all of our issues are solved with the new release. :)

@andrenarchy
Copy link
Member

The carousel works again but not as expected (content slides to the wrong side). The log messages remain.

@nschloe does it break anything? :)

@nschloe
Copy link
Contributor Author

nschloe commented Aug 3, 2015

For me, the carousel does work as expected.
Other than that, I find everything else working as expected as well.

@nschloe
Copy link
Contributor Author

nschloe commented Aug 12, 2015

The latest update brings a proper carousel fix.

@nschloe
Copy link
Contributor Author

nschloe commented Aug 12, 2015

The pdf.js warning is reported at mozilla/pdf.js#6306.

@nschloe
Copy link
Contributor Author

nschloe commented Aug 12, 2015

Apparently, it's expected normal to get the warning, cf. mozilla/pdf.js#6306 (comment).

Since the typeahead deprecation warning is also being worked on, I'd consider this PR good to go for now.

@andrenarchy
Copy link
Member

Alright, now MathJax brings in an error when comments are rendered on, see here. It tries to load about:blank as a font which results

Font from origin 'null' has been blocked from loading by Cross-Origin Resource Sharing policy: Received an invalid response. Origin 'https://paperhive.org' is therefore not allowed access.

@nschloe
Copy link
Contributor Author

nschloe commented Aug 13, 2015

Upstream claims "this isn't an error", cf. mathjax/MathJax#926.

andrenarchy added a commit that referenced this pull request Aug 13, 2015
@andrenarchy andrenarchy merged commit 0564126 into master Aug 13, 2015
@nschloe nschloe deleted the deps branch August 31, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants