Path.compare() fails with intermediate point added

[iconexperience]

Here is a simple example where Path.compare() works only in one direction, but not the other:

var p1 = new paper.Path({segments: [[100, 100], [150, 100], [200, 100], [200, 200], [100, 200]], closed: true});
var p2 = new paper.Path({segments: [[100, 100], [200, 100], [200, 200], [100, 200]], closed: true});
console.log(p1.compare(p2)); // true
console.log(p2.compare(p1)); // false

The paths look like this.

p1:

p2:

[iconexperience]

Wow, Curve.getOverlaps() returns the overlaps in the wrong order:

var v1 = [0, 0, 0, 0, 100, 0, 100, 0];
var v2 = [50, 0, 50, 0, 100, 0, 100, 0];
var overlaps = Curve.getOverlaps(v1, v2);
console.log(overlaps); // [ [ 1, 1 ], [ 0.5, 0 ] ]

[lehni]

Interesting! I just found the same to be a problem. Will changing the overlap sequence have any other impacts?

[lehni]

I think I've managed to fix this in 8845391, but I found another failing scenario:

var circle = new Path.Circle({
    center: [100, 100],
    radius: 100,
    fullySelected: true
});

var circle2 = circle.clone();
circle2.divideAt(50);
circle2.divideAt(100);

console.log(circle.compare(circle2)); // false
console.log(circle2.compare(circle)); // true

Note: The example needs the latest develop version for Path#divideAt()

[lehni]

c21e19b is the correct fix, and also made the code more readable. This should explain the change:

        // Iterate through all end points:
        // First p1 of curve 1 & 2, then p2 of curve 1 & 2.