Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curve-intersection not found between two intersecting curves. #1284

Closed
lehni opened this issue Mar 18, 2017 · 2 comments
Closed

Curve-intersection not found between two intersecting curves. #1284

lehni opened this issue Mar 18, 2017 · 2 comments
Assignees
@lehni
Labels
cat: curve-intersection type: bug

Comments

@lehni
Copy link
Member

lehni commented Mar 18, 2017 •
edited

Sketch 1

Looks like this commit was premature: 89e31dd
@lehni lehni self-assigned this Mar 18, 2017
@lehni
Copy link
Member Author

lehni commented Mar 18, 2017 •
edited

Here's another case:

Sketch 2

@lehni
Copy link
Member Author

lehni commented Mar 18, 2017

This also affects path.getIntersections(path), which never worked in case of sketch 1, because the bounding boxes do not touch (they are ~1e-13 apart from each other). This needs addressing too.

@lehni lehni closed this as completed in 830a80a Mar 18, 2017
lehni added a commit that referenced this issue Mar 18, 2017
@lehni
Intersections: Bring back special handling of curve end-points.
fdd4207 
Revert commit 89e31dd, and add further improvements:

- Implement unit tests for #1284
- Remove Rectangle#touches(rect) in favor of #intersects(rect, epsilon)

Closes #1284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lehni lehni

Labels
cat: curve-intersection type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lehni