Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounds break, when empty group is added #1467

Closed
lexa274 opened this issue Mar 26, 2018 · 0 comments
Closed

Bounds break, when empty group is added #1467

lexa274 opened this issue Mar 26, 2018 · 0 comments
Assignees
@sasensi
Labels
status: PR proposed an active pull request should fix this issue type: bug

Comments

@lexa274
Copy link

lexa274 commented Mar 26, 2018

I've noticed strange behaviour of item's bounds, when its children list contains some empty groups.
I'm using JavaScript directly, tried only in Chrome.

Here is a fiddle with a test case. Both layers in the fiddle should look the same.
@sasensi sasensi self-assigned this Oct 5, 2018
sasensi added a commit to sasensi/paper.js that referenced this issue Oct 6, 2018
@sasensi
Fix bounds error with nested empty items
735ecb9 
- add an optional parameter to Item#isEmpty() allowing to check
emptiness recursively
- ignore all recursively empty items in bounds calculation
Closes paperjs#1467
@sasensi sasensi mentioned this issue Oct 6, 2018
Closed
2 tasks
@sasensi sasensi added type: bug status: PR proposed an active pull request should fix this issue labels Nov 23, 2018
@lehni lehni closed this as completed in eeb2643 Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sasensi sasensi

Labels
status: PR proposed an active pull request should fix this issue type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bounds error with nested empty items sasensi/paper.js
2 participants
@lexa274 @sasensi