Add Line.getDistance() and use it in Curve.getOverlaps() #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a static function
getDistance()
to line, that simply callsLine.getSignedDistance()
and returns the absolute value. This makes theLine
API a bit more symmetrical, which already has the mathodgetDistance
for theLine
prototype.In Curve.getOverlaps() we create a new instance of
Line
and at least one instance ofPoint
to check if the two curves are overlapping lines. This is done for each pair of curves and the result is false in the vast majority of cases. Since this generates quite a lot of garbage for little effect, so I though it would be nice to implement a way that does the same without producing garbage. Also, the new code is smaller when minified, so this compensates a little bit for the extra code inLine
.