fix issue with svg import of raster images #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing rasters after load if the image has a matrix with any translation/skew value the image will calculate the wrong matrix after loading. In order to correct this we append the translation rather than prepend so that it happens in the correct order relative to the transformation.
park9140
force-pushed
the
fix-issue-with-svg-import-of-raster-images
branch
from
5bcb3a5
to
74bb49d
Compare
|
Tests on this would pass if develop branch were passing. Would really love to have an npm package update with this fix. |
|
Awsome! I am egaerly waiting for this patch, right now I am using ugly hacks to circumvent the issue. But how does #1348 relate to this issue? |
|
@lilltiger Oh good catch, I typed 1348 rather than #1328. Fixed. I have a copy of this built in a branch on my fork that i'm installing from for now. Branched off of the v0.11.5 tag |
|
LGTM, thanks @park9140 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When importing rasters after load if the image has a matrix with any translation/skew value
the image will calculate the wrong matrix after loading.
In order to correct this we append the translation rather than prepend so
that it happens in the correct order relative to the transformation.
Related issues
Checklist