Fix handling of negative Shape.Rectangle sizes #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
force-pushed
the
fix-negative-shape-size
branch
2 times, most recently
from
7cd045c
to
f96c43e
Compare
adroitwhiz
force-pushed
the
fix-negative-shape-size
branch
from
f96c43e
to
c2f26a6
Compare
|
Great, thank you for the flawless PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the handling of negative Shape.Rectangle sizes by taking the absolute value of the shape's
sizeto calculate the shape's newradiusinShape.setSize.Related issues
Resolves #1245
Checklist
npm run jshintpasses)