custom events #674
Merged
custom events #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (entry.install && handlers.length == 1) | ||
| entry.install.call(this, type); | ||
| } | ||
| var entry = this._eventTypes[type], |
There was a problem hiding this comment.
This assumes that _eventTypes exists, which is not true when there are no _events on class. This is case for example of Project class.
|
Looks good, thanks! Will merge and then look into details, such as the comment above by @jardakotesovec. |
lehni
added a commit
that referenced
this pull request
May 13, 2015
|
@jardakotesovec this has been addressed in 6b428f5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables listening to custom event types without explicit declaration in classes as proposed in #670. There are basic emitter tests as well.