MatchingModel.name should not be unique anymore

[odelseth]

The feature-permissions branch has been merged in dev but the MatchingModel still has a name field with unique=True.
This prevents two users having the same tag name, for instance.

Just removing the unique=True may cause issues elsewhere or more dev. My proposition:

• MatchingModel should inherit from ModelWithOwner (all models inheriting MatchingModel also inherit ModelWithOwner at the moment)
• Remove unique=True from name field
• Add a unique_together = ["owner", "name"] to MatchingModel's Meta class

[shamoon]

Good point. That seems like a reasonable plan to me, unless others see any issue with this. Would you like to submit a PR for this or we can implement?

[shamoon]

Ps. Theres another piece to this which is if an object's owner is changed we will have to ensure unique as well

[shamoon]

Believe this does it: #2827

[odelseth]

I've pulled your branch feature-owner-aware-unique-model-names, done some manual tests and everything seems OK.
Thanks for the quick implementation.

[github-actions[bot]]

This discussion has been automatically closed because it was marked as answered.

[github-actions[bot]]

This discussion has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.