Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rework query params logic #1000

Merged
merged 5 commits into from May 26, 2022
Merged

Fix: Rework query params logic #1000

merged 5 commits into from May 26, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 21, 2022

Proposed change

This PR significantly reworks the frontend query params logic, it does not really change the way things work for the user 馃槄. Ok, well actually it does because its faster and it avoids a significant possible duplication. The code is also less confusing and just better (imho of course). I channeled ol' Winkler on this when I remembered something he told me about the DocumentListViewService. Incidentally, this also fixes the linked issue below (see, better!).

Fixes #997

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other: code improvement

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added bug Bug report or a Bug-fix enhancement New feature frontend labels May 21, 2022
@shamoon shamoon added this to the Next Release milestone May 21, 2022
@shamoon shamoon requested a review from a team as a code owner May 21, 2022 07:32
@shamoon shamoon self-assigned this May 21, 2022
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label May 21, 2022
@shamoon shamoon linked an issue May 24, 2022 that may be closed by this pull request
@lippoliv
Copy link
Contributor

@shamoon nice work. Especially the duplicated requests is something I came across the last days, good to know, that your change maybe fixes this :)

Copy link
Member

@qcasey qcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well from what I can see. Lucky number 1000?

@qcasey qcasey merged commit ee1ef4f into dev May 26, 2022
@qcasey qcasey deleted the rework-query-params-logic branch May 26, 2022 15:18
@shamoon shamoon mentioned this pull request Jun 1, 2022
34 tasks
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix enhancement New feature frontend non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Applying filters on page >1 throws error
3 participants