Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR significantly reworks the frontend query params logic, it does not really change the way things work for the user 馃槄. Ok, well actually it does because its faster and it avoids a significant possible duplication. The code is also less confusing and just better (imho of course). I channeled ol' Winkler on this when I remembered something he told me about the
DocumentListViewService
. Incidentally, this also fixes the linked issue below (see, better!).Fixes #997
Type of change
Checklist:
pre-commit
hooks, see documentation.I have made corresponding changes to the documentation as needed.