Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CI: Build and tag container on PRs" #106

Merged
merged 1 commit into from Feb 19, 2022

Conversation

qcasey
Copy link
Member

@qcasey qcasey commented Feb 19, 2022

Reverts #79

This is failing in many different ways I didn't expect and needs to be revisited.

  1. Write permissions are not given to outside forks (for security) failed here
  2. Whatever is going on here...

Anyway, it's creating unnecessarily failed checks and is annoying. I'll retest and get some input from the CI team this week.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1869923691

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.084%

Totals Coverage Status
Change from base Build 1869905235: 0.0%
Covered Lines: 3920
Relevant Lines: 4257

💛 - Coveralls

@qcasey qcasey merged commit 165b476 into dev Feb 19, 2022
@qcasey qcasey deleted the revert-79-ci-build-container-on-prs branch February 19, 2022 21:09
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants