Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Interaction between barcode and directories as tags #1303

Merged
merged 1 commit into from Jul 29, 2022

Conversation

stumpylog
Copy link
Member

Proposed change

When a barcode file containing file is split, previously the newly created files were placed into the CONSUMPTION_DIR. However, if the consumer is working recursively and tagging documents based on the path of the barcode document, this means the split files won't have the correct tags.

This PR fixes the behavior by placing new split files into the same directory as the original file was.

Fixes #1294

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner July 29, 2022 17:26
@stumpylog stumpylog added the bug Bug report or a Bug-fix label Jul 29, 2022
@gador
Copy link
Contributor

gador commented Jul 29, 2022

This LGTM! Thanks for the fix @stumpylog

@qcasey qcasey merged commit 4b45e94 into dev Jul 29, 2022
@qcasey qcasey deleted the bugfix-barcode-and-dirs branch July 29, 2022 19:25
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] CONSUME_SUBDIRS_AS_TAGS not working when using CONSUMER_ENABLE_BARCODES
3 participants