Fix: missing tooltip translation & filter editor wrapping

[shamoon]

Proposed change

This small PR addresses two (unrelated) issues reported in 1.8.0, the first a missing translation string and the second the fact that the filter editor text field can become too short on certain screen sizes. Regarding the second issue, fix was to increase the breakpoint at which everything goes to one line from 1200 --> 1400 px (e.g. at user's screen size things will now be on two lines). Screenshot below is new minimum width to illustrate, its still small but acceptable I think.

Fixes #1299
Fixes #1300

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Other (please explain)

Checklist:

• I have read & agree with the contributing guidelines.
• If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
• If applicable, I have checked that all tests pass, see documentation.
• I have run all pre-commit hooks, see documentation.
• I have made corresponding changes to the documentation as needed.
• I have checked my modifications for any breaking changes.

[tooomm]

Looking at your screenshot, it's still small indeed. Probably even smaller for other languages...
Could there be a minimum size for the search area, where it no more shrinks but pushes the other buttons to the second line?

On mobile, it switches to icon-only filter buttons at one point. Maybe that's a reasonable solution for smaller desktop/laptop/tablet screens as well?

[qcasey]

Looking at your screenshot, it's still small indeed. Probably even smaller for other languages...

This is true, unfortunately this PR doesn't fix for other languages (try German). The longer titles of the other items push the field small once again.

[shamoon]

Hmm, actually should be OK in German, that’s where I tested it. But I will double-check.

We discussed this a bit in the original Storage paths PR, it was always going to be a trade-off. The “fix” (barring a more sig UI change is just pushing the limit at which we keep things on two lines (eg currently 1200, PR goes to 1400, could go further…) but yea, it’s a compromise.

But I will double-check this a bit later

[qcasey]

But I will double-check this a bit later

OK thanks, let us know might be just my chromium.

pushing the limit at which we keep things on two lines (eg currently 1200, PR goes to 1400, could go further…)

As @tooomm suggested would a min-width fix longer languages while not sacrificing shorter ones? See these two screenshots with 150px min width on the input, in German the Reset Filters button gets kicked to a second line while it's unchanged in English.

[shamoon]

Yea I think this is the best compromise, thanks. Here's a screenshot around 1450px on German and English with newest changes:

[qcasey]

Awesome, thanks for the fix

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.