Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct browser unsaved changes warning #1369

Merged
merged 1 commit into from
Aug 7, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Aug 7, 2022

Proposed change

This PR corrects an issue in 1.8.0 where the user was being shown a browser 'unsaved changes' after a document was opened, edited and then closed without saving. Video demonstrates the fix. As it turns out, this was not trivial. As always would welcome testing.

1366.mov

Fixes #1366

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added bug Bug report or a Bug-fix frontend labels Aug 7, 2022
@shamoon shamoon added this to the v1.8.1 milestone Aug 7, 2022
@shamoon shamoon requested a review from a team as a code owner August 7, 2022 03:23
@shamoon shamoon self-assigned this Aug 7, 2022
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label Aug 7, 2022
@shamoon shamoon linked an issue Aug 7, 2022 that may be closed by this pull request
Copy link
Member

@qcasey qcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this works well in my testing

@shamoon shamoon merged commit ef0080b into dev Aug 7, 2022
@shamoon shamoon deleted the fix/browser-unsaved-changes branch August 7, 2022 22:43
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Leave Website? popup
2 participants