Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: created_date should not be required #1412

Merged
merged 1 commit into from Aug 14, 2022
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Aug 13, 2022

Proposed change

This tiny PR fixes an issue reported with 1.8.0 API is requiring created_date

Fixes #1411

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon
Copy link
Member Author

shamoon commented Aug 13, 2022

@paperless-ngx/backend Weird the backend tests are failing here with

...
File "/home/runner/.local/share/virtualenvs/paperless-ngx-3FlfLCzB/lib/python3.8/site-packages/_pytest/assertion/rewrite.py", line 168, in exec_module
[51](https://github.com/paperless-ngx/paperless-ngx/runs/7819842630?check_suite_focus=true#step:7:52)
    exec(co, module.__dict__)
[52](https://github.com/paperless-ngx/paperless-ngx/runs/7819842630?check_suite_focus=true#step:7:53)
  File "/home/runner/.local/share/virtualenvs/paperless-ngx-3FlfLCzB/lib/python3.8/site-packages/pytest_sugar.py", line 17, in <module>
[53](https://github.com/paperless-ngx/paperless-ngx/runs/7819842630?check_suite_focus=true#step:7:54)
    from packaging.version import parse
[54](https://github.com/paperless-ngx/paperless-ngx/runs/7819842630?check_suite_focus=true#step:7:55)
ModuleNotFoundError: No module named 'packaging'

Maybe something on dev got messed up?

@stumpylog
Copy link
Member

stumpylog commented Aug 13, 2022

Yeah, it's not this change. Unsure why atm, but despite the Pipfile.lock listing packaging, it isn't installed. I'll look into it further when I can.

Sigh, it's pipenv: pypa/pipenv/issues/5247

@shamoon shamoon force-pushed the fix/created-date-not-required branch from c6804dc to 8183de4 Compare August 14, 2022 07:58
@shamoon shamoon merged commit 87953cb into dev Aug 14, 2022
@shamoon shamoon deleted the fix/created-date-not-required branch August 14, 2022 23:06
@qcasey qcasey added the bug Bug report or a Bug-fix label Aug 15, 2022
@Buddinski88
Copy link

@shamoon since release 1.8.1 has now become 1.9.0. Is there any way to get the fix earlier? Then I can finally get on with importing my documents :-)

@shamoon
Copy link
Member Author

shamoon commented Sep 11, 2022

@shamoon since release 1.8.1 has now become 1.9.0. Is there any way to get the fix earlier? Then I can finally get on with importing my documents :-)

Not really, as a small team we only maintain one release branch. But we should be releasing 1.9 soon!

Edit: #1560 =)

@qcasey
Copy link
Member

qcasey commented Sep 12, 2022

The quickest way to a fix would be to make a backup of your setup and then change the container tag from latest to beta. We would appreciate any testing!

@Buddinski88
Copy link

@shamoon that's totally understandable and i'm still excited about what you're doing here! Thank you :-)
@qcasey thanks for the hint. I'm switching to beta tonight and will report back as soon as I find a bug.

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] API returns 500 whenever a PATCH request without "created_date" is sent to the documents endpoint
4 participants