New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Preserve original filename in metadata #1440
Feature: Preserve original filename in metadata #1440
Conversation
Hello @GwynHannay, thank you very much for submitting this PR to us! This is what will happen next:
Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby. |
If you don't mind, I'd like to cherry pick your commits a bit to clean up the history. It will mean you'll need to do a fetch and reset to instead of pull though. Let me know if that's a problem. |
Please feel free! :-) |
Pull Request Test Coverage Report for Build 2900289856
💛 - Coveralls |
The changes look good to me. I think it would be nice to extend this just a touch more for people though:
|
Agree its less useful if its not visible, I will add the frontend part |
Awesome!! Thank you so much - I couldn't, for the life of me, work out how to add it to the front end, haha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the value to the post consume data as well. Looks good, thanks for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to all three of you
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
This change adds a metadata field to capture the original filename of the document being uploaded. For some, there can be important information in the original filename not captured within the document, so it is important to preserve this information.
Right now this field will only be displayed in the admin UI.
Fixes #874
Type of change
Checklist:
pre-commit
hooks, see documentation.