Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing filter rule types to SavedViewFilterRule model & fix migrations #1463

Merged
merged 2 commits into from Aug 26, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Aug 26, 2022

Proposed change

This small PR addresses an issue where certain filter rules cause a view to be unable to be saved. This bug is actually present for a couple other filter rule types (ASN > and ASN <) so I added those too.

Edit: this PR now also includes a fix to the 'comments' and 'original filename' database migrations (ok to fix because they haven't been released yet) and a migration for this fix.

Screen Shot 2022-08-26 at 8 29 20 AM

Fixes #1462

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added the bug Bug report or a Bug-fix label Aug 26, 2022
@shamoon shamoon added this to the v1.8.1 milestone Aug 26, 2022
@shamoon shamoon requested a review from a team as a code owner August 26, 2022 15:31
@shamoon shamoon self-assigned this Aug 26, 2022
@shamoon shamoon linked an issue Aug 26, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 26, 2022

Pull Request Test Coverage Report for Build 2935333811

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 92.502%

Files with Coverage Reduction New Missed Lines %
documents/models.py 2 98.22%
Totals Coverage Status
Change from base Build 2930411616: 0.003%
Covered Lines: 4898
Relevant Lines: 5295

💛 - Coveralls

@shamoon shamoon changed the title Fix: Add missing filter rule types to SavedViewFilterRule model Fix: Add missing filter rule types to SavedViewFilterRule model & fix migrations Aug 26, 2022
@qcasey qcasey merged commit 8046a6f into dev Aug 26, 2022
@qcasey qcasey deleted the fix/issue-1462 branch August 26, 2022 19:35
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Can't create views with different storage paths
4 participants