Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Simplify IMAP login for UTF-8 #1492

Merged
merged 1 commit into from Sep 1, 2022
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

With the release of imap_tools 0.57.0, there is now a login_utf8 method which encapsulates all the logic we were doing manually. I checked the new method with a UTF-8 password and could list the folders, so it works and reduces our code.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner September 1, 2022 15:55
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label Sep 1, 2022
@stumpylog stumpylog removed the non-trivial Requires approval by several team members label Sep 1, 2022
Copy link
Member

@tribut tribut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code! Excellent! 😼

@shamoon shamoon merged commit a502fe7 into dev Sep 1, 2022
@shamoon shamoon deleted the feature-imap-utf-improve branch September 1, 2022 16:35
@shamoon
Copy link
Member

shamoon commented Sep 1, 2022

Thanks!

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants