Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document comments not updating on document navigation #1566

Merged
merged 2 commits into from Sep 12, 2022
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Sep 12, 2022

Proposed change

This PR fixes an issue in the 1.9.0 beta where comments weren't correctly updating when navigating between documents (without closing). I also included an unrelated visual fix for an unwanted border on the user dropdown (resultant from recent bootstrap update). Video included for reference

comment.mov

Fixes #1564

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon added bug Bug report or a Bug-fix frontend labels Sep 12, 2022
@shamoon shamoon added this to the v1.9.0 milestone Sep 12, 2022
@shamoon shamoon self-assigned this Sep 12, 2022
@shamoon shamoon requested a review from a team as a code owner September 12, 2022 15:37
@shamoon shamoon linked an issue Sep 12, 2022 that may be closed by this pull request
@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label Sep 12, 2022
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely fixes the issue I was seeing. The frontend changes generally make sense

@shamoon shamoon merged commit 16882b8 into beta Sep 12, 2022
@shamoon shamoon deleted the fix/issue-1564 branch September 12, 2022 18:37
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v1.9.0 RC1 Bug - Comments appear to be on all documents
2 participants