Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reset button padding on small screens #1646

Merged
merged 1 commit into from Sep 26, 2022
Merged

Fix reset button padding on small screens #1646

merged 1 commit into from Sep 26, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Sep 26, 2022

Proposed change

This tiny PR fixes a visual bug I noted with the filter editor 'Reset' button in 1.9.0 so figured can sneak it into 1.9.1 bugfix release. Before/after screenshot below

after

PNG image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner September 26, 2022 17:56
@shamoon shamoon added this to the Next Minor Release milestone Sep 26, 2022
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Sep 26, 2022
stumpylog
stumpylog approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The visual part seems good

@shamoon shamoon merged commit 6e21d3d into main Sep 26, 2022
@shamoon shamoon deleted the fix/reset-button-padding branch September 26, 2022 18:03
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stumpylog stumpylog stumpylog approved these changes

Assignees
No one assigned
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Paperless-ngx
Archived in project
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shamoon @stumpylog