Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: downgrade channels-redis #1802

Merged
merged 1 commit into from Oct 14, 2022
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

Downgrades channels-redis to 3.4.1, due to django/channels_redis#332. When that is fixed, upgrading should be fine.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain) - dependency maintinence

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner October 14, 2022 19:52
@stumpylog stumpylog added the dependencies Pull requests that update a dependency file label Oct 14, 2022
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess this didnt break any tests and just silently failed?

@stumpylog
Copy link
Member Author

We don't have any testing I know of which actually tries to consume a file asynchronously, which would have noticed this. And you'd think they'd have noticed it before the release of v4.

The errors on the dependabot pull request were all due to it trying to find a Redis server to connect with. Maybe if one had existed, it would have been seen then.

@stumpylog stumpylog merged commit 0df0deb into dev Oct 14, 2022
@stumpylog stumpylog deleted the chore-downgrade-channels-redis branch October 14, 2022 23:48
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants