Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Simplified registry cleanup #1812

Merged
merged 3 commits into from Oct 20, 2022
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

It always annoyed me the cleanup for our installer images was checking the feature- existence, when that's not relevant. So I've rewritten the cleaning to be class based, with only the main image and its cache caring about feature-* branches. The logic is otherwise the same logic as before.

I also updated the workflow to run more in parallel, and included the confirmation step of all images pulling after cleaning for everything which gets cleaned.

I know it's still probably complicated, so if I can diagram or explain something more in the files to help with understanding, let me know.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain) - Maintenance

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested review from a team as code owners October 16, 2022 15:40
@paperless-ngx-secretary paperless-ngx-secretary bot added ci-cd non-trivial Requires approval by several team members labels Oct 16, 2022
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know if others feel differently (Bueller?) but I'm happy to take your word for it on this one, if it works it works...

@stumpylog
Copy link
Member Author

I know, I've learned a bunch about the registry and the GitHub API. If I knew Javascript, I'd package the logic up into an action.

@stumpylog stumpylog merged commit 4c7242d into dev Oct 20, 2022
@stumpylog stumpylog deleted the chore-cleanup-tags-simpler branch October 20, 2022 19:42
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci-cd non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants