Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allows configuring barcodes with pdf2image instead of pikepdf #1857

Merged
merged 1 commit into from Oct 24, 2022
Merged

Fix: Allows configuring barcodes with pdf2image instead of pikepdf #1857

merged 1 commit into from Oct 24, 2022

Conversation

stumpylog
Copy link
Member

Proposed change

A simple change which adds the option for users to utilize the old pdf2image method for detecting barcodes. This method is not the default, but some files and scanners produce images or PDF structures which just don't play nicely with pikepdf.

Fixes #1850, Fixes #1856

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner October 24, 2022 15:45
@paperless-ngx-secretary paperless-ngx-secretary bot added backend documentation Improvements or additions to documentation non-trivial Requires approval by several team members labels Oct 24, 2022
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Oct 24, 2022
shamoon
shamoon approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

This was linked to issues Oct 24, 2022
[BUG] Barcode seperator processing fails with password protected PDFs #1850
Closed
[BUG] Barcode separation not working in 1.9.* but 1.8.0 #1856
Closed
@stumpylog stumpylog merged commit f8ce628 into dev Oct 24, 2022
@stumpylog stumpylog deleted the fix/1850-1856-legacy-fallback branch October 24, 2022 16:58
@stumpylog stumpylog mentioned this pull request Nov 3, 2022
Closed
@stumpylog stumpylog removed the documentation Improvements or additions to documentation label Nov 10, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shamoon shamoon shamoon approved these changes

Assignees
No one assigned
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
Paperless-ngx
Archived in project
Milestone
No milestone
2 participants
@stumpylog @shamoon