Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Handle password protected PDFs during barcode detection #1858

Merged
merged 1 commit into from Oct 25, 2022

Conversation

stumpylog
Copy link
Member

Proposed change

If an input PDF is password protected, consumption would fail entirely. With this change, such PDFs will be skipped for barcode detection and consumption on them can be further attempted.

In general, something happening during barcode detection will let the file pass as is, where it may be consumed or fail further down the pipeline.

Fixes #1850

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner October 24, 2022 20:20
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Oct 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3315905997

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 92.671%

Files with Coverage Reduction New Missed Lines %
documents/barcodes.py 2 97.96%
Totals Coverage Status
Change from base Build 3314634896: 0.01%
Covered Lines: 5020
Relevant Lines: 5417

💛 - Coveralls

@shamoon shamoon added this to the Next Release milestone Oct 25, 2022
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamoon shamoon merged commit 37a892d into dev Oct 25, 2022
@shamoon shamoon deleted the fix/1850-barcode-password branch October 25, 2022 06:17
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Barcode seperator processing fails with password protected PDFs
3 participants