Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use a maintained upload-release-asset #2055

Merged
merged 1 commit into from Nov 28, 2022

Conversation

stumpylog
Copy link
Member

Proposed change

The release run had some warnings about Node 12 actions and set-output usage. This transitions us to a new, maintained action which I think should resolve the warnings.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain) - maintenance

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally defer to you, I guess they archived that one in favor of https://github.com/softprops/action-gh-release but we only need the upload-release-asset part of things?

@stumpylog
Copy link
Member Author

Yeah, the release-drafter action handles creating the release (and the changelog), but it doesn't do the upload. It suggests the now archived action for that.

@stumpylog stumpylog merged commit b33fcc1 into dev Nov 28, 2022
@stumpylog stumpylog deleted the chore-maintained-release-asset branch November 28, 2022 18:01
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants