Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add libatomic for armv7 compatibility #2066

Merged
merged 2 commits into from Nov 29, 2022
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

The ARMv7 wheel built by piwheels differs somehow from the official amd64 and aarch64, in that it needs libatomic installed. So install it in the image (for all arches).

I also took the opportunity to group up things in the packages.

Fixes #2052

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary paperless-ngx-secretary bot added the non-trivial Requires approval by several team members label Nov 29, 2022
@stumpylog stumpylog removed the non-trivial Requires approval by several team members label Nov 29, 2022
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Nov 29, 2022
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your dark arts ci skills are the best, thank you.

Wonder if we should release a minor version fix soon with this?

@stumpylog
Copy link
Member Author

I took the easy way this time and just installed the library instead of figuring out what piwheels is doing wrong.

Not sure why it isn't more prevalent. Perhaps most people are on aarch64 with their Pis now. But yes, should probably get a few more fixes in and release a .1

@stumpylog stumpylog added this to the v1.10.1 milestone Nov 29, 2022
@stumpylog stumpylog merged commit 3a74f24 into dev Nov 29, 2022
@stumpylog stumpylog deleted the fix/2052-libatomic branch November 29, 2022 21:46
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] After Upgrade to 1.10.0 - libatomic.so.1: cannot open shared object file: No such file or directory
2 participants