Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Incompatible URL schemes for socket based Redis #2092

Merged
merged 2 commits into from Dec 3, 2022

Conversation

stumpylog
Copy link
Member

@stumpylog stumpylog commented Dec 2, 2022

Proposed change

celery vs channels-redis use different URL schemes to specify using a socket. Adds a decently simple layer to convert from one to the other, so both can work happily with a socket and user's don't need to think too much about which format.

Also supports translation of the DB number aka virtual host.

Fixes #2072

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner December 2, 2022 21:40
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels Dec 2, 2022
@stumpylog stumpylog removed the non-trivial Requires approval by several team members label Dec 2, 2022
@github-actions github-actions bot added the enhancement New feature label Dec 2, 2022
@stumpylog stumpylog added bug Bug report or a Bug-fix and removed enhancement New feature labels Dec 2, 2022
@stumpylog stumpylog changed the title Bugfix: Allow using Redis with a socket Bugfix: Incompatible URL schemes for socket based Redis Dec 2, 2022
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

fix was verified in #2072 (comment)

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Impossible to connect to redis using a unix socket
2 participants