Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support tags__id__none in advanced search, fix tags filter badge count for excluded #2205

Merged
merged 2 commits into from Dec 24, 2022

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Dec 18, 2022

Proposed change

Fixes the linked issue where tags__id__none isnt currently supported in 'advanced search' (whoosh). Also fixed a frontend bug this made me notice where excluded (x) items in the tags dropdown aren't showing a badge count when they should be.

Fixes #2204

Screen Shot 2022-12-17 at 7 48 20 PM

Screen Shot 2022-12-17 at 7 48 07 PM

Screen Shot 2022-12-17 at 7 48 12 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners December 18, 2022 03:52
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Dec 18, 2022
@shamoon shamoon changed the title Fix: support tags__id__none in advanced search, tags filter badge count for excluded Fix: support tags__id__none in advanced search, fix tags filter badge count for excluded Dec 18, 2022
@shamoon shamoon merged commit 5435dc2 into dev Dec 24, 2022
@shamoon shamoon deleted the fix-2204 branch December 24, 2022 00:27
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Filtering is inconsistent: tag exclusion does not apply with search term
2 participants