New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arabic language to frontend #2313
Conversation
Hello @KhaledEmad7, thank you very much for submitting this PR to us! This is what will happen next:
Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby. |
Thanks. As this is our first RTL lang in the UI I wasn’t sure if the UI would need other adjustments. Did you find it still legible, usable etc? |
688e57f
to
ec18985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. We'll merge this for now, there's been some issue with the arabic translation file Im trying to sort out but it does look like the UI is largely translated and if there are significant RTL issues we can iron them out.
Yes, the UI is fine but there are still some missing changes needed to be done in the translation, I have made another PR for that hope it helps. |
The only change that can improve UX is making the front-end right aligned instead of left; however, the translation doesn't need any changes. |
@KhaledEmad7 Have a look at #2302 and give it a try. :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
Fixes # (issue)
Type of change
Checklist:
pre-commit
hooks, see documentation.