Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic language to frontend #2313

Merged
merged 1 commit into from Jan 2, 2023
Merged

Conversation

KhaledEmad7
Copy link
Contributor

Proposed change

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@paperless-ngx-secretary
Copy link

Hello @KhaledEmad7,

thank you very much for submitting this PR to us!

This is what will happen next:

  1. My robotic colleagues will check your changes to see if they break anything. You can see the progress below.
  2. Once that is finished, human contributors from paperless-ngx review your changes. Since this seems to be a small change, only a single contributor has to review your changes.
  3. Please improve anything that comes up during the review until your pull request gets approved.
  4. Your pull request will be merged into the dev branch. Changes there will be tested further.
  5. Eventually, changes from you and other contributors will be merged into main and a new release will be made.

Please allow up to 7 days for an initial review. We're all very excited about new pull requests but we only do this as a hobby.
If any action will be required by you, please reply within a month.

@shamoon shamoon changed the title Dev Add Arabic language to frontend Jan 2, 2023
@shamoon
Copy link
Member

shamoon commented Jan 2, 2023

Thanks. As this is our first RTL lang in the UI I wasn’t sure if the UI would need other adjustments. Did you find it still legible, usable etc?

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. We'll merge this for now, there's been some issue with the arabic translation file Im trying to sort out but it does look like the UI is largely translated and if there are significant RTL issues we can iron them out.

@shamoon shamoon merged commit 91e3302 into paperless-ngx:dev Jan 2, 2023
@KhaledEmad7
Copy link
Contributor Author

Yes, the UI is fine but there are still some missing changes needed to be done in the translation, I have made another PR for that hope it helps.

@shamoon shamoon added this to the Next Release milestone Jan 4, 2023
@KhaledEmad7
Copy link
Contributor Author

The only change that can improve UX is making the front-end right aligned instead of left; however, the translation doesn't need any changes.

@tooomm
Copy link
Contributor

tooomm commented Jan 7, 2023

@KhaledEmad7 Have a look at #2302 and give it a try. :)

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants