Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: preview content remains hidden on mobile #2346

Merged
merged 1 commit into from Jan 4, 2023
Merged

Fix: preview content remains hidden on mobile #2346

merged 1 commit into from Jan 4, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 4, 2023

Proposed change

Man I wish the frontend had like 300% more tests.

Screen Shot 2023-01-04 at 6 59 44 AM

Fixes #2344

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner January 4, 2023 15:02
@shamoon shamoon linked an issue Jan 4, 2023 that may be closed by this pull request
@shamoon shamoon self-assigned this Jan 4, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 4, 2023
@sukisoft
Copy link

sukisoft commented Jan 4, 2023

Thanks! Is there a Chance of releasing this within e.g. in 1.11.4?

@shamoon
Copy link
Member Author

shamoon commented Jan 4, 2023

Thanks! Is there a Chance of releasing this within e.g. in 1.11.4?

Yes I think so

@stumpylog
Copy link
Member

Be the change you want to see? 🧪++

@shamoon
Copy link
Member Author

shamoon commented Jan 4, 2023

Be the change you want to see? 🧪++

Haha yes, when I have the occasional fit of patience!

@shamoon shamoon merged commit 8e83f90 into dev Jan 4, 2023
@shamoon shamoon deleted the fix-2344 branch January 4, 2023 23:35
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] PDF-Preview not visible on mobile / small screens
3 participants