Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: include comments in advanced search #2351

Merged
merged 2 commits into from Jan 6, 2023
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 5, 2023

Proposed change

This was on the list back when comments were added, hopefully should make them more useful. Adding them to the search was pretty straightforward (first commit), I danced with whoosh a bit for the permissions stuff. But adding the highlighting Im not so totally certain about, open to other solutions, but this seems to work.

Screen Shot 2023-01-04 at 7 05 16 PM

Screen Shot 2023-01-04 at 6 55 23 PM

Fixes #1654
Fixes #687
See #1375

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners January 5, 2023 06:20
@paperless-ngx-secretary paperless-ngx-secretary bot added backend frontend non-trivial Requires approval by several team members labels Jan 5, 2023
@github-actions github-actions bot added the enhancement New feature label Jan 5, 2023
@shamoon shamoon added this to the Next Release milestone Jan 6, 2023
@shamoon shamoon merged commit a0eecb8 into dev Jan 6, 2023
@shamoon shamoon deleted the feature-comment-search branch January 6, 2023 02:48
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend enhancement New feature frontend non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants