Feature: include comments in advanced search #2351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This was on the list back when comments were added, hopefully should make them more useful. Adding them to the search was pretty straightforward (first commit), I danced with whoosh a bit for the permissions stuff. But adding the highlighting Im not so totally certain about, open to other solutions, but this seems to work.
Fixes #1654
Fixes #687
See #1375
Type of change
Checklist:
pre-commit
hooks, see documentation.