Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subpath for websockets #2371

Merged
merged 1 commit into from Jan 8, 2023
Merged

Fix subpath for websockets #2371

merged 1 commit into from Jan 8, 2023

Conversation

tribut
Copy link
Member

@tribut tribut commented Jan 7, 2023

Proposed change

Adds the missing subpath info for websocket URLs.

Fixes #2252

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@tribut tribut requested a review from a team as a code owner January 7, 2023 19:39
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 7, 2023
@tribut
Copy link
Member Author

tribut commented Jan 7, 2023

@davidgiga1993 when you have the time, can you confirm that this change fixes your issue? Thanks.

@coveralls
Copy link

coveralls commented Jan 7, 2023

Pull Request Test Coverage Report for Build 3863624503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 92.652%

Totals Coverage Status
Change from base Build 3859909105: -0.02%
Covered Lines: 5409
Relevant Lines: 5838

💛 - Coveralls

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks! This was pretty much a change I had locally but wasn’t sure about, so works for me! but hopefully we can get confirmation elsewhere too

@stumpylog stumpylog linked an issue Jan 8, 2023 that may be closed by this pull request
@davidgiga1993
Copy link

@tribut Yep works fine, thanks!

@tribut tribut merged commit 7b37191 into dev Jan 8, 2023
@tribut tribut deleted the fix-subpath-websockets branch January 8, 2023 13:58
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] Websockets do not respect subpath
5 participants