Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include optional socket file in release #2409

Merged
merged 1 commit into from Jan 11, 2023
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

It was pointed out in #2405 the optional webserver socket file isn't included from the scripts folder. It's optional, but users may use it, and it is mentioned in the docs.

Fixes #2405

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner January 11, 2023 15:35
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 11, 2023
@coveralls
Copy link

coveralls commented Jan 11, 2023

Pull Request Test Coverage Report for Build 3894282512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.65%

Totals Coverage Status
Change from base Build 3894170138: 0.03%
Covered Lines: 5420
Relevant Lines: 5850

💛 - Coveralls

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@stumpylog stumpylog merged commit 9e33344 into dev Jan 11, 2023
@stumpylog stumpylog deleted the fix/2405-missing-socket branch January 11, 2023 19:53
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix ci-cd small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Issues in the bare metal setup guide
3 participants