Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow setting mailrule order from frontend #2459

Merged
merged 1 commit into from Jan 17, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 17, 2023

Proposed change

Does what it says on the tin

Fixes #2455

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners January 17, 2023 19:03
@shamoon shamoon linked an issue Jan 17, 2023 that may be closed by this pull request
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 17, 2023
@coveralls
Copy link

coveralls commented Jan 17, 2023

Pull Request Test Coverage Report for Build 3942442488

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.611%

Totals Coverage Status
Change from base Build 3941897400: -0.1%
Covered Lines: 5339
Relevant Lines: 5765

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3942442488

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 92.721%

Files with Coverage Reduction New Missed Lines %
documents/signals/handlers.py 1 88.57%
Totals Coverage Status
Change from base Build 3941897400: -0.02%
Covered Lines: 5439
Relevant Lines: 5866

💛 - Coveralls

@shamoon shamoon merged commit 284e0d3 into dev Jan 17, 2023
@shamoon shamoon deleted the fix-frontend-mail-rule-ordering branch January 17, 2023 23:31
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] unable to change mail rule order in new frontend
3 participants