Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: comments not showing in search until after manual reindex in v1.12 #2513

Merged
merged 2 commits into from Jan 25, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jan 25, 2023

Proposed change

This PR fixes the linked issue that adding / deleting a comment currently doesnt trigger search index reindexing. Also fixes a small visual issue I noted for displaying comment search hit results on large cards.

Fixes #2511

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested review from a team as code owners January 25, 2023 20:07
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Jan 25, 2023
@shamoon shamoon changed the title Fix 2511 Fix: comments not showing in search until after manual reindex in v1.12 Jan 25, 2023
@shamoon shamoon linked an issue Jan 25, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Jan 25, 2023

Pull Request Test Coverage Report for Build 4009553994

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 92.707%

Files with Coverage Reduction New Missed Lines %
documents/views.py 14 95.33%
Totals Coverage Status
Change from base Build 4008771095: -0.03%
Covered Lines: 5555
Relevant Lines: 5992

💛 - Coveralls

@shamoon shamoon merged commit 8e8b2d7 into dev Jan 25, 2023
@shamoon shamoon deleted the fix-2511 branch January 25, 2023 20:16
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Extended search in comments doesn’t work
3 participants