Fix comment search highlight + multi-word search #2542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fixes the issue with searching for multi-word comments and fixes some issues that can with comment search highlighting.
Comment searching has proved to be a bit more complicated than I realized, honestly mostly because I find the whoosh docs to be opaque, but thats on me. The fix here is mostly to let whoosh handle the highlighting on its own instead of trying to mess with it. I also took the opportunity to allow for visual highlighting more than one comment. See screenshots of all
Fixes #2536
Type of change
Checklist:
pre-commit
hooks, see documentation.I have made corresponding changes to the documentation as needed.