Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long dropdown contents break document detail column view #2638

Merged
merged 2 commits into from Feb 10, 2023
Merged

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Feb 10, 2023

Proposed change

Pure css fixes here, one for the referenced issue and another small thing I noticed with the dropdown button for download not having rounded right corners (I swear I already fixed that...). CSS fixes can be a little finicky but obviously I tested in the major browsers

Fixes #2637

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner February 10, 2023 04:24
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 10, 2023
@shamoon shamoon linked an issue Feb 10, 2023 that may be closed by this pull request
@shamoon shamoon merged commit bc91b83 into dev Feb 10, 2023
@shamoon shamoon deleted the fix-2637 branch February 10, 2023 19:51
@shamoon shamoon added this to the v1.12.3 milestone Feb 12, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Too long correspondent name moves document preview
2 participants