Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove files produced by barcode splitting when completed #2648

Merged
merged 1 commit into from Feb 12, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

After incoming files have been split via one of the barcode options, the produced files are saved to somewhere in the consumption directory. But they weren't removed from the temporary directory used to save them. So clean those up, and the directory as well.

May partly address #2639

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner February 12, 2023 02:28
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels Feb 12, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #2648 (95fc13c) into dev (7bfb11a) will increase coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##              dev    #2648      +/-   ##
==========================================
+ Coverage   93.11%   93.16%   +0.05%     
==========================================
  Files         140      140              
  Lines        5997     6057      +60     
==========================================
+ Hits         5584     5643      +59     
- Misses        413      414       +1     
Flag Coverage Δ
backend 93.16% <83.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/documents/tasks.py 92.25% <71.42%> (+0.10%) ⬆️
src/documents/barcodes.py 100.00% <100.00%> (ø)
src/documents/consumer.py 96.38% <0.00%> (+0.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stumpylog stumpylog merged commit 8b3d01c into dev Feb 12, 2023
@stumpylog stumpylog deleted the fix/2639-extra-files-left branch February 12, 2023 16:20
@shamoon shamoon added this to the v1.12.3 milestone Feb 12, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend bug Bug report or a Bug-fix non-trivial Requires approval by several team members
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants