Chore: Faster Docker image cleanup #2687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Alright, I got fed up with the cleaning taking nearly an hour, all of that due to the confirmation step I added.
Now, instead of pulling every tag for every image, the tool uses inspection to confirm the index for a tag can be found and the digests the index points to (the actual image data with layers) can also be found and inspected. The assumption being, if something were deleted inadvertently, it will no longer be inspectable, because it's gone.
It helps to know that indexes have a list of descriptors where the
digest
field points to the actual image manifest. This change simple follows the linkage to the end, but without downloading the image layers.Type of change
Checklist:
pre-commit
hooks, see documentation.