Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add missing i18n for mobile preview tab title #2692

Merged

Conversation

nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Feb 17, 2023

Proposed change

  • Add the translation for the "Preview" pane on mobile view
  • (not sure about this one) Fixed documentation for extracting i18n data in the UI. ng xi18n --ivy didn't work on my computer (command not found), and I found ng extract-i18n on the Angular documentation. But I'm not familiar at all with Angular, so revert this commit if it's not supposed to be like this.
Before After
image image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@nathanaelhoun nathanaelhoun requested a review from a team as a code owner February 17, 2023 13:18
@paperless-ngx-secretary paperless-ngx-secretary bot added documentation Improvements or additions to documentation frontend non-trivial Requires approval by several team members labels Feb 17, 2023
@nathanaelhoun nathanaelhoun changed the title fix: fix missing i18n for mobile preview fix: add missing i18n for mobile "preview" pane Feb 17, 2023
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 17, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great with one small change: translations are updated via crowdin and it’s better to do it there (other changes are made to the file, keeps things in sync etc)

so yea, if you’re able to remove the change to the FR file that’d be great. LMK if you need help doing that

And you’re totally correct about the command to extract strings, had no idea that old one was there :)

Thanks!

@shamoon shamoon force-pushed the fix-missing-i18n-for-mobile-preview branch from 977de5c to 08f5d9a Compare February 17, 2023 15:14
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took care of adjusting the commits (helpful you had them separated).

Again, after merging you'll be able to submit the actual translation via crowdin.

Thanks again

@shamoon shamoon changed the title fix: add missing i18n for mobile "preview" pane Fix: add missing i18n for mobile preview tab title Feb 17, 2023
@shamoon shamoon merged commit 754286c into paperless-ngx:dev Feb 17, 2023
@shamoon shamoon added this to the v1.14 milestone Feb 17, 2023
@nathanaelhoun nathanaelhoun deleted the fix-missing-i18n-for-mobile-preview branch February 17, 2023 16:15
@nathanaelhoun
Copy link
Contributor Author

Thanks for the review @shamoon! Was not sure if commiting the FR translation was good, now I'll know :-)
Translation submitted through Crowdin.
Have a nice day!

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix documentation Improvements or additions to documentation frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants