New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add missing i18n for mobile preview tab title #2692
Fix: add missing i18n for mobile preview tab title #2692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great with one small change: translations are updated via crowdin and it’s better to do it there (other changes are made to the file, keeps things in sync etc)
so yea, if you’re able to remove the change to the FR file that’d be great. LMK if you need help doing that
And you’re totally correct about the command to extract strings, had no idea that old one was there :)
Thanks!
977de5c
to
08f5d9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took care of adjusting the commits (helpful you had them separated).
Again, after merging you'll be able to submit the actual translation via crowdin.
Thanks again
Thanks for the review @shamoon! Was not sure if commiting the FR translation was good, now I'll know :-) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
ng xi18n --ivy
didn't work on my computer (command not found), and I foundng extract-i18n
on the Angular documentation. But I'm not familiar at all with Angular, so revert this commit if it's not supposed to be like this.Type of change
Checklist:
pre-commit
hooks, see documentation.