Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bulk edit reset apply button state #2701

Merged
merged 1 commit into from Feb 20, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Feb 18, 2023

Proposed change

Tiny bug I noticed where the Apply button stays active even after applying a bulk edit, see video for illustration.

New:

new.mov

Old:

old.mov

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner February 18, 2023 22:32
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Feb 18, 2023
@shamoon shamoon added this to the v1.14 milestone Feb 19, 2023
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's attention to detail

@shamoon shamoon merged commit 73b1b94 into dev Feb 20, 2023
@shamoon shamoon deleted the fix-bulk-edit-reset-apply-button branch February 20, 2023 02:40
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug report or a Bug-fix frontend small-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants