New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Stronger typing for file consumption #2744
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2744 +/- ##
==========================================
- Coverage 93.22% 93.20% -0.02%
==========================================
Files 154 152 -2
Lines 6497 6435 -62
==========================================
- Hits 6057 5998 -59
+ Misses 440 437 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
8129ac1
to
009ce2f
Compare
009ce2f
to
7c1ac05
Compare
fc2805a
to
60c1c53
Compare
60c1c53
to
92f055e
Compare
…typing of arguments and setting of some information about the file only once
92f055e
to
d7cafbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All issues look resolved, thanks stumpy!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
This is a larger change, but I think worthwhile to make. It creates 2 data classes for handling typing and serialization of types when calling the main shared task
consume_file
. Some of the benefits I can think of:Fixes # (issue)
Type of change
Checklist:
pre-commit
hooks, see documentation.