Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow mail account to use access tokens #2930

Merged
merged 3 commits into from Mar 23, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

Allows a user to provide an access token for mail account authentication, instead of using a password. This is a new checkbox, since there's no way to tell the password is a token.

The source of the token is up to the user, depending on their mail account and server, etc.

#2296 #2707

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested review from a team as code owners March 22, 2023 18:58
@paperless-ngx-secretary paperless-ngx-secretary bot added backend frontend non-trivial Requires approval by several team members labels Mar 22, 2023
@github-actions github-actions bot added the enhancement New feature label Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #2930 (32076d9) into dev (4637e33) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2930      +/-   ##
==========================================
+ Coverage   93.17%   93.46%   +0.29%     
==========================================
  Files         153      154       +1     
  Lines        6445     6595     +150     
==========================================
+ Hits         6005     6164     +159     
+ Misses        440      431       -9     
Flag Coverage Δ
backend 93.46% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/paperless_mail/serialisers.py 98.07% <ø> (ø)
src/paperless_mail/mail.py 88.51% <100.00%> (+0.11%) ⬆️
...rless_mail/migrations/0020_mailaccount_is_token.py 100.00% <100.00%> (ø)
src/paperless_mail/models.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Tiny stuff on the frontend. Should this also be mentioned in the docs?

@shamoon shamoon added this to the v1.14 milestone Mar 23, 2023
@stumpylog stumpylog merged commit d246e40 into dev Mar 23, 2023
29 checks passed
@stumpylog stumpylog deleted the feature-bearer-token-mail branch March 23, 2023 15:52
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend enhancement New feature frontend non-trivial Requires approval by several team members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants