Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Capture celery and kombu logs to a file #2954

Merged
merged 2 commits into from Mar 26, 2023

Conversation

stumpylog
Copy link
Member

Proposed change

Not really a fix for #2787, but perhaps having the logs captured will allow further debugging or a better bug report to celery.

I also disabled gossip and mingle, which are only relevant if you're running multiple workers in a cluster to allow synchronization between workers.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Celery stuff has the funniest names. Just thinking out loud (and not that it needs to be part of this PR) but wondering if we should include this log on the frontend

@stumpylog
Copy link
Member Author

I guess their naming is green, healthy things? I'd never heard of kombu.

The logs could move to the frontend at some point. But it didn't look super interesting when just running normally

@stumpylog stumpylog merged commit 5468394 into dev Mar 26, 2023
31 checks passed
@stumpylog stumpylog deleted the feature-log-celery-to-file branch March 26, 2023 02:17
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants