Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable images to be released on Quay.io #2972

Merged
merged 1 commit into from Mar 29, 2023
Merged

Conversation

stumpylog
Copy link
Member

Proposed change

This updates the workflow to allow our images to also be pushed to Redhat's Quay.io repository, following the same rules as our pushes to Docker Hub. If should all work perfectly, but I won't know for certain until it's in dev, as feature branches are not pushed to the other registries.

For maintainers and admins, I can add you to the organization on Quay.io if desired. Shoot me a message on Matrix if you want access.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@stumpylog stumpylog requested a review from a team as a code owner March 29, 2023 17:51
@github-actions github-actions bot added the enhancement New feature label Mar 29, 2023
@shamoon shamoon added this to the v1.14 milestone Mar 29, 2023
Copy link
Member

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, yes I love the idea of not being reliant on any of these when the next docker-hub-pocalypse happens (and then un-happens)

@stumpylog stumpylog merged commit 15a264d into dev Mar 29, 2023
31 checks passed
@stumpylog stumpylog deleted the feature-quay-io branch March 29, 2023 18:35
@stumpylog
Copy link
Member Author

Fingers crossed the action incident has been resolved and this actually is testable

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants