Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment API version for 1.14.1+ #3191

Merged
merged 1 commit into from Apr 26, 2023
Merged

Increment API version for 1.14.1+ #3191

merged 1 commit into from Apr 26, 2023

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Apr 26, 2023

Proposed change

Fixes #3186

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain)

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner April 26, 2023 06:45
@github-actions github-actions bot added the bug Bug report or a Bug-fix label Apr 26, 2023
@shamoon shamoon added this to the v1.14.1 milestone Apr 26, 2023
stumpylog
stumpylog approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, there have been some larger api changes for sure

@shamoon shamoon merged commit c385355 into dev Apr 26, 2023
31 checks passed
@shamoon shamoon deleted the fix/increment-api-version branch April 26, 2023 15:36
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stumpylog stumpylog stumpylog approved these changes

Assignees
No one assigned
Labels
backend bug Bug report or a Bug-fix small-change
Projects
None yet
Milestone
v1.14.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shamoon @stumpylog